[ompushkara]

Summary

Checklist

• All commits are signed-off, using DCO
• All new code has docstrings and type annotations
• All new code is covered by tests. Aim for at least 90% coverage. CI is configured to highlight lines not covered by tests.
• Public facing changes are paired with documentation changes
• Release note has been added to CHANGELOG.md if needed

[qodo-for-securesign]

PR Summary by Qodo

Declare pyOpenSSL as a direct runtime dependency

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

---

AI Description

• Add pyOpenSSL as a direct dependency so fresh installs provide the required OpenSSL import.
• Document the installation failure caused by sigstore no longer supplying pyOpenSSL.

Diagram

graph TD
  A["rh-model-signing"] --> B["Certificate signing"] --> C["pyOpenSSL"]
  A -->|direct dependency| C

Loading

High-Level Assessment

Declaring pyOpenSSL directly is the appropriate fix for an existing runtime import. Continuing to rely on sigstore's transitive dependencies would leave fresh installations vulnerable to upstream dependency changes.

Files changed (2) +6 / -0

Bug fix (1) +1 / -0

pyproject.tomlDeclare pyOpenSSL as a runtime dependency +1/-0

Declare pyOpenSSL as a runtime dependency

• Adds pyOpenSSL to the project's direct dependencies so installations include the package imported by certificate-signing code.

pyproject.toml

Documentation (1) +5 / -0

CHANGELOG.mdDocument the missing-OpenSSL installation fix +5/-0

Document the missing-OpenSSL installation fix

• Adds an Unreleased fix entry explaining that sigstore 4.5.1 no longer installs pyOpenSSL and linking the resulting fresh-install failure to issue #685.

CHANGELOG.md

[qodo-for-securesign]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

---

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

---

Powered by Qodo

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (0c73b0d) to head (1844c46).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files          21       21           
  Lines        1974     1974           
=======================================
  Hits         1597     1597           
  Misses        377      377           

Flag	Coverage Δ
unit	80.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.