#6062 Fix dupplicate rename AIS requests - #6067
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The functional change is small and targeted, with only a minor spelling nit identified in a newly added comment.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR addresses duplicate rename (AIS) requests triggered during inventory item renaming by ensuring the renamer’s text is cleared after issuing a rename, so any subsequent commit-on-focus-lost path won’t re-send the same rename.
Changes:
- Add explanatory comments clarifying why
commitRename()callsfinishRenamingItem()without checking renamer visibility (focus-lost commit path). - After calling
mRenameItem->rename(...), clear the renamer text to prevent duplicate rename requests when multiple commit paths fire.
File summaries
| File | Description |
|---|---|
| indra/llui/llfolderview.cpp | Clears renamer text after rename to prevent duplicate rename requests; adds comments describing focus-lost behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
maxim-productengine
approved these changes
Jul 29, 2026
akleshchev
force-pushed
the
andreyk/viewer_6062
branch
from
July 29, 2026 20:26
37974aa to
e29b1b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mRenameItem->rename( new_name ); checks for empty string, so this is enough to avoid dupplciates.