Show five-digit precision for texture transforms - #6049
Conversation
|
Using IEEE numbers are not accurate. They get used mostly by default -- being the root cause. The only solution, still, is using decimals, but that takes more engineering work. C# has fully implemented decimals if you want to try them. You'll get more digits with decimals. Not a showstopper but it will matter. |
|
Thanks for the context, @Dzonatas. This PR is intentionally scoped to #1861: it changes the display precision of the existing Replacing the numeric representation would be a substantially broader architectural change and would be better handled separately. For this issue, the goal is to avoid the editor immediately redisplaying entered transform values rounded to only three decimal places, while remaining consistent with the existing Viewer data model. If the maintainers prefer a broader approach, I’m happy to follow their guidance. |
|
Thanks for pointing this out. I widened all 12 texture scale/offset spinners in commit I also re-ran the XML and pre-commit checks successfully. |
|
There are issues, yes, especially with what leftovers that are available each day. My default response is to move and resize the tab. If it is more than serious, block the mail port. Offer some bottled water while we wait. Do something for about a half hour. Now type in a review. It will be appreciated. |
|
Addressed in 3a7c775.\n\n- Restored the uniform 265 px total width so the transform spinners line up with the neighboring controls.\n- Kept the increase compact: the label width is now 195 px (instead of 175 px), adding only enough field space for the extra digit.\n- Applied the same five-decimal precision and compact sizing to the PBR scale and offset controls.\n\nThe XML and pre-commit checks pass locally. |

Summary
Root cause
The transform spinners inherited the global three-decimal default. Values with greater precision could be submitted, but the controls immediately displayed a rounded value, which could overwrite the original value on a subsequent commit.
Validation
pre-commit run --from-ref upstream/develop --to-ref HEADpanel_tools_texture.xmland verifieddecimal_digits="5"on all 12 scale/offset controlsgit diff --check upstream/develop...HEADFixes #1861