Fix error popup saying voice is incompatible with region voice - #6046
Open
roxanneskelly wants to merge 1 commit into
Open
Fix error popup saying voice is incompatible with region voice#6046roxanneskelly wants to merge 1 commit into
roxanneskelly wants to merge 1 commit into
Conversation
There is a race condition where voice can start up before the voice server type is retrieved from the region. Since the voice server type defaults to null, and that wasn't allowed, a popup message happened. The default voice type is webrtc, so we connect to that in cases where the voice server type is empty.
cosmic-linden
approved these changes
Jul 24, 2026
akleshchev
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition where voice can start up before the voice server type is retrieved from the region. Since the voice server type defaults to null, and that wasn't allowed, a popup message happened.
The default voice type is webrtc, so we connect to that in cases where the voice server type is empty.
Since this is a rare issue, we can't really repro it, so test guidance is simply to
log in or TP a bunch of times.