Budget incremental reflection probe updates - #6033
Draft
LisaScheers wants to merge 1 commit into
Draft
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a token-bucket CPU budget for incremental, non-realtime reflection probe face updates.
The scheduler measures actual update time, smooths the observed cost, accrues a configurable allowance each frame, and caps idle credit. It forces progress after 30 deferred frames so probe generation cannot stall indefinitely.
RenderReflectionProbeUpdateBudgetdefaults to 1 ms per frame. Setting it to0restores the previous unthrottled behavior. Explicit realtime probes retain their existing six-face-per-frame behavior.A native Apple Silicon profile of the closely related Firestorm viewer placed
LLReflectionMapManager::update()/doProbeUpdate()on roughly 8% of main-thread samples even with static-only reflections. The officialdevelopbranch contains the same one-face-per-frame incremental scheduler.Related Issues
Issue Link: None; opened as a draft for upstream performance evaluation.
Checklist
Additional Notes
Validation performed:
git diff --checkxmllint --noout indra/newview/app_settings/settings.xmlA full official viewer build was not available because this host lacks the autobuild dependency bundle and full Xcode toolchain. This remains a draft pending native build and benchmark coverage.