BUG: make sed command POSIX sed

[VirtualTim]

\+ is a GNU extension. This will not work on BSD sed.
I believe both commands are functionally equivilent.

[pcmoore]

Hi @VirtualTim, thanks for the patch! I just approved the GH actions to run on this PR, so we will see how it turns out. @drakenclimber and I will also take a look and perhaps do a back-to-back comparison of the two sed commands to ensure the results are the same.

Aside from that, could you please add a sign-off to your patch and perhaps change the subject line to something like "gperf: make sed command POSIX sed safe"? More information can be found in our CONTRIBUTING.md doc.

[drakenclimber]

Changes look good to me.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

Here's what I did to verify:

• I asked Oracle AI to convert the original sed snippet to BSD-compatible sed. It generated the same output (with minor whitespace differences)
• I applied this patch to a local libseccomp build and compared its binary outputs to the head commit
  • nm resulted in the same output
  • readelf resulted in the same output
  • objdump had minor differences, but I believe this is cosmetic

I don't have a BSD system currently, so I didn't do any tests there.

[VirtualTim]

Hey @drakenclimber, what's the next step here? Are you waiting on anything from me to get this merged?

[drakenclimber]

Hey @drakenclimber, what's the next step here? Are you waiting on anything from me to get this merged?

Nope, you're good to go for the moment.

Both @pcmoore and I usually try to approve pull requests. A second set of eyes is really helpful. Let's wait for his review.