Search for the closest .luaurc to the source file - #339
Merged
jeparlefrancais merged 13 commits intoJul 13, 2026
Conversation
Stefanuk12
added a commit
to Stefanuk12/darklua
that referenced
this pull request
Jul 20, 2026
Brings staging up to date with latest upstream/main (incl. seaofvoices#339 'closest .luaurc when bundling') and the hybrid-mode branch, which had already reconciled the upstream locator-pattern refactor with the hybrid require mode. Conflicts (all in the require/luaurc subsystem) resolved in favour of hybrid-mode's reconciled versions, which supersede staging's older pre-seaofvoices#339 luaurc code while preserving all features (incl. the use_luau_configuration toggle, relocated into load_aliases): - src/rules/require/hybrid_path_locator.rs (lifetime signatures) - src/rules/require/luau_path_locator.rs (RefCell interior mutability) - src/rules/require/luau_require_mode.rs (initialize/load_aliases) staging's own changes (pesde integration, etc.) preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it only gets the closest
.luaurcsource file to the entry point. This happens because the aliases are only initialised per block, rather than per source file. This PR forces a.luaurclookup for each source file encountered that contains a require call with an alias..luaurclookup for closest to source file