Make BenchmarkConfig.compute support instance configuration in YAML#592
Open
Make BenchmarkConfig.compute support instance configuration in YAML#592
Conversation
Contributor
R-Palazzo
commented
Apr 10, 2026
| gpu_type: nvidia-tesla-t4 | ||
| gpu_count: 1 | ||
| swap_gb: 64 | ||
| name_prefix: sdgym-run |
Collaborator
Author
There was a problem hiding this comment.
I went with this approach to stay consistent with what already exists.
I wonder whether in the future it would be better to support a higher-level image config that resolves the image for the user, keep boot_image only as an explicit override, or support both.
image:
flavor: dlvm
os: ubuntu
os_version: "22.04"
cuda: "12.8"
fealho
requested changes
Apr 10, 2026
fealho
reviewed
Apr 10, 2026
fealho
approved these changes
Apr 10, 2026
amontanez24
reviewed
Apr 10, 2026
sdgym/_benchmark_launcher/utils.py
Outdated
|
|
||
| def resolve_compute(compute): | ||
| """Resolve the compute configuration based on the benchmark config.""" | ||
| return _resolve_compute_gcp(compute) |
Contributor
There was a problem hiding this comment.
can we add a check here that determines the service we are using for compute and then do
if service == 'gcp':
return _resolve_compute_gcp()
elif service == 'aws:
...
else:
raise Error('service must be one of ...')
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 85.15% 85.12% -0.03%
==========================================
Files 41 40 -1
Lines 3563 3544 -19
==========================================
- Hits 3034 3017 -17
+ Misses 529 527 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
R-Palazzo
force-pushed
the
issue-586-compute-yaml
branch
from
4aa044b to
ad42d49
Compare
amontanez24
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #586
CU-86b94u5fd