Repository navigation
Reach 100% line coverage and fix absolute-path command signing - #933
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 17 examples covering the remaining untested validation, plugin loading and signing, branch configuration, processor contention, and platform fallback paths. Local line coverage reaches 100% (3,822/3,822), with all existing tests preserved and coverage filters unchanged.
The signing tests exposed an absolute-path bug: joining an absolute command path to the repository root produced a nonexistent path, so command contents were omitted from approval signatures. Resolve command paths with
File.expand_pathand verify that changes to both absolute and relative command files require fresh approval.Validation: