Skip to content

Reach 100% line coverage and fix absolute-path command signing - #933

Merged
sds merged 1 commit into
mainfrom
test/full-line-coverage
Nov 10, 2026
Merged

sds merged 1 commit into
mainfrom
test/full-line-coverage

Conversation

@sds

@sds sds commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Adds 17 examples covering the remaining untested validation, plugin loading and signing, branch configuration, processor contention, and platform fallback paths. Local line coverage reaches 100% (3,822/3,822), with all existing tests preserved and coverage filters unchanged.

The signing tests exposed an absolute-path bug: joining an absolute command path to the repository root produced a nonexistent path, so command contents were omitted from approval signatures. Resolve command paths with File.expand_path and verify that changes to both absolute and relative command files require fresh approval.

Validation:

  • Fresh full suite: 2,090/2,090 examples verified, zero failures.
  • Fresh LCOV report: 3,822/3,822 executable lines covered (100%).
  • All pre-commit checks pass, including RuboCop.
  • All 20 GitHub Actions jobs pass across Ruby 3.3, 3.4, and 4.0 on Linux and Windows.
  • All 18 CI coverage artifacts combined: 3,824/3,824 executable lines covered (100%). Each Linux Ruby version independently reports 100% as well.

@sds
sds merged commit 25fe1ff into main Nov 10, 2026
21 checks passed
@sds
sds deleted the test/full-line-coverage branch November 10, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant