[REFACTOR] Enhance SlimmableWavenet model management#258
Merged
sdatkinson merged 5 commits intomainfrom Apr 28, 2026
Merged
Conversation
- Introduced a staging model mechanism to allow for smoother transitions between model configurations without interrupting real-time processing. - Refactored the model rebuilding logic into separate functions for clarity and maintainability. - Updated the SetSlimmableSize method to utilize the new staging approach, improving performance during model updates.
…ions - Replaced unique_ptr with shared_ptr for active and staging models to enable safe concurrent access. - Introduced StagedSlimModel struct to encapsulate model and channel information for atomic staging. - Updated model rebuilding and staging logic to utilize atomic operations, ensuring data-race-free transitions during processing. - Enhanced process, prewarm, and Reset methods to work with the new atomic staging mechanism, improving real-time performance.
…l handling - Refactored pending model management to use a consistent approach for both libc++ and other STL implementations. - Introduced private methods for atomic operations on the pending staged model, enhancing clarity and maintainability. - Updated model rebuilding and staging logic to utilize the new methods, ensuring data-race-free transitions during processing.
- Introduced a new option, NAM_USE_LIBCXX_LINUX, to allow users to select libc++ for Linux builds. - Updated CMakeLists.txt to conditionally link against stdc++fs or libc++ based on the new option. - Enhanced compatibility for projects using Clang with libc++ on Linux, improving build flexibility.
Exercises the _LIBCPP_VERSION code path; checkout v4 on both jobs. Made-with: Cursor
synchu
pushed a commit
to synchu/NeuralAmpModelerCore
that referenced
this pull request
Apr 29, 2026
* [REFACTOR] Enhance SlimmableWavenet model management - Introduced a staging model mechanism to allow for smoother transitions between model configurations without interrupting real-time processing. - Refactored the model rebuilding logic into separate functions for clarity and maintainability. - Updated the SetSlimmableSize method to utilize the new staging approach, improving performance during model updates. * [REFACTOR] Improve SlimmableWavenet model handling with atomic operations - Replaced unique_ptr with shared_ptr for active and staging models to enable safe concurrent access. - Introduced StagedSlimModel struct to encapsulate model and channel information for atomic staging. - Updated model rebuilding and staging logic to utilize atomic operations, ensuring data-race-free transitions during processing. - Enhanced process, prewarm, and Reset methods to work with the new atomic staging mechanism, improving real-time performance. * [REFACTOR] Update SlimmableWavenet atomic operations for pending model handling - Refactored pending model management to use a consistent approach for both libc++ and other STL implementations. - Introduced private methods for atomic operations on the pending staged model, enhancing clarity and maintainability. - Updated model rebuilding and staging logic to utilize the new methods, ensuring data-race-free transitions during processing. * [FEATURE] Add option for using libc++ on Linux in CMake configuration - Introduced a new option, NAM_USE_LIBCXX_LINUX, to allow users to select libc++ for Linux builds. - Updated CMakeLists.txt to conditionally link against stdc++fs or libc++ based on the new option. - Enhanced compatibility for projects using Clang with libc++ on Linux, improving build flexibility. * Add GitHub Actions job to build and test with libc++ on Linux Exercises the _LIBCPP_VERSION code path; checkout v4 on both jobs. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #257