feat: move hashsolo to sc.pp - #4303
Open
flying-sheep wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4303 +/- ##
==========================================
+ Coverage 80.01% 80.06% +0.05%
==========================================
Files 132 133 +1
Lines 13397 13406 +9
==========================================
+ Hits 10719 10733 +14
+ Misses 2678 2673 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
flying-sheep
marked this pull request as ready for review
August 18, 2026 11:15
selmanozleyen
approved these changes
Aug 19, 2026
selmanozleyen
left a comment
Member
There was a problem hiding this comment.
Some edge cases inherited from main and one new behaviour with the pd.unique and loc usage instead of the old np.unique. Plus one nitpick on dead return variables. But the rest seems good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just moving the code over and adding an
anndata.accbased version of the API on top.People had issues with our old API since it only supported
obscolumns:The new API of course supports everything! Yay accessors!
sc.external.pp.hashsolointosc.pp#4304