Open
Conversation
…_mle_zero_padding
…/ceno into feat/prover_mle_zero_padding
506a380 to
df88dec
Compare
2147c5d to
d1ab71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the GPU prover compact/default-aware for MLE inputs while keeping protocol-facing behavior unchanged. The verifier, PCS dimensions, transcript, and sumcheck domains still use the logical domain; only GPU-resident prover data can stay compact by occupied rows.
Companion CUDA kernel changes: scroll-tech/ceno-gpu#146.
Compact vs logical domains
num_vars, power-of-two padding, and rotation expansion remain verifier-visible and unchanged.tail_default. Most witness tails are zero; logup shared numerator can use one.Flow modes
CENO_GPU_ENABLE_WITGEN=0: CPU witgen still produces host traces; GPU proving extracts/copies occupied rows into compact GPU MLE specs while preserving logicalnum_varsfor constraints and sumcheck.CENO_GPU_ENABLE_WITGEN=1: GPU witgen can feed compact device-backed traces or replay-materialized inputs directly into the same compact proving path.Proving semantics
Unified paths
Reviewer focus
num_vars.tail_defaulthandling in sumcheck/tower, especially non-zero logup numerator defaults.CENO_GPU_ENABLE_WITGEN=0/1andCENO_CONCURRENT_CHIP_PROVING=0/1.Benchmark
Source runs:
Block:
23817600. Per-operation app-prove rows are profile totals across overlapped shard work, so they can exceed wall time; E2E/app-prove rows are the wall-time comparison.Peak memory is extracted from concurrent benchmark job logs by taking the max of
[gpu device]snapshots.pool_bookedis scheduler reservation/estimate, not actual VRAM usage.cuda_usedpool_usedpool_reservedpool_bookedSummary: wall time is slightly faster in this run (
81.9s -> 80.9s). Peak VRAM is lower (cuda_used:23637.19 MB -> 21557.19 MB, -2080.00 MB/ -8.80%;pool_reserved:23136.00 MB -> 21056.00 MB, -2080.00 MB/ -8.99%). Compact tower build is materially faster (4.711s -> 3.413s), while the overlapped tower proving profile total is higher (178.197s -> 188.436s); because chip proving overlaps across shards, the wall-time result is the primary performance signal.Validation commands