Skip to content

Some linking tests are bad #25

Description

@scriptype

From linking.spec.js:

  t.test('skips non-link properties', t => {
    const node = makeNode({
      slug: 'source',
      title: 'Hello',
      count: 42
    })
    resolveLinks(node, [])
    t.equal(node.getLinks().length, 0, 'no links created for plain properties')
    t.end()
  })

No links will be created, anyway, if the 2nd parameter to resolveLinks (nodes) is an empty array.

All unit tests should be checked against this kind of sloppy shit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions