fix(deps): update dependency cookie to v1.1.1#519
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cookie dependency used by scratch-gui from 0.6.0 to 1.1.1, and adjusts the two call sites that parse document.cookie to align with the updated package’s export shape.
Changes:
- Bump
cookiedependency inpackages/scratch-guito^1.1.1and updatepackage-lock.jsonaccordingly. - Update theme and color-mode persistence helpers to import and use
parsedirectly fromcookie.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/scratch-gui/src/lib/settings/theme/persistence.js | Switch cookie parsing to import {parse} from 'cookie' and use parse(document.cookie) |
| packages/scratch-gui/src/lib/settings/color-mode/persistence.js | Same import/update for color-mode cookie parsing |
| packages/scratch-gui/package.json | Update cookie dependency version to ^1.1.1 |
| package-lock.json | Lockfile update to cookie@1.1.1 with updated metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
KManolov3
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Bump dependency
cookieto v1.1.1Reason for Changes
Version 0.6.0 has a security issue, and #293 conservatively bumps it to a version that doesn't have that issue. However, that version is still very old. This PR bumps to the latest version, which only required minor adjustments. (The security issue doesn't affect the way we use the package, but it's still best to keep up to date.)
Test Coverage
Unchanged