Skip to content

match [*|attr!=value] like :not([*|attr=value]) - #216

Merged
wRAR merged 1 commit into
scrapy:masterfrom
itecz26:wildcard-attrib-not-equal
Nov 12, 2026
Merged

wRAR merged 1 commit into
scrapy:masterfrom
itecz26:wildcard-attrib-not-equal

Conversation

@itecz26

@itecz26 itecz26 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

xpath_attrib() translates [*|label!=bar] to a node-set != comparison that is true when any matching attribute differs, so it matches <item a:label="bar" b:label="baz"/> even though the docs define [foo!=bar] as :not([foo=bar]) (and with i only the first attribute gets compared), so this builds it from the per-attribute equality predicate #207 added for the other operators.

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (6be624a) to head (0446a37).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   99.80%   99.92%   +0.12%     
==========================================
  Files           3        3              
  Lines        1002     1359     +357     
  Branches      166      300     +134     
==========================================
+ Hits         1000     1358     +358     
  Misses          1        1              
+ Partials        1        0       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wRAR wRAR closed this Nov 9, 2026
@wRAR wRAR reopened this Nov 9, 2026
@wRAR
wRAR merged commit 1730a48 into scrapy:master Nov 12, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants