Skip to content

search_date period separator support#963

Draft
gavishpoddar wants to merge 66 commits into
scrapinghub:masterfrom
gavishpoddar:fixing-translation
Draft

search_date period separator support#963
gavishpoddar wants to merge 66 commits into
scrapinghub:masterfrom
gavishpoddar:fixing-translation

Conversation

@gavishpoddar
Copy link
Copy Markdown
Contributor

@gavishpoddar gavishpoddar commented Aug 13, 2021

This PR solves the below issues, it adds support for date objects like 12.12.2000 (separated by .)

Tests are added for these cases

Thanks and Pl suggest if changes are required

Originally from #963

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2021

Codecov Report

❌ Patch coverage is 96.31902% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.10%. Comparing base (507dc6d) to head (b54890e).
⚠️ Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
dateparser/search/search.py 94.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   98.29%   98.10%   -0.19%     
==========================================
  Files         234      235       +1     
  Lines        2694     2698       +4     
==========================================
- Hits         2648     2647       -1     
- Misses         46       51       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gavishpoddar and others added 28 commits August 18, 2021 20:41
Co-authored-by: Konstantin Lopuhin <kostia.lopuhin@gmail.com>
@gavishpoddar
Copy link
Copy Markdown
Contributor Author

This PR is currently broken

@gavishpoddar gavishpoddar marked this pull request as draft October 11, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant