Repository navigation
perf: skip atomic clears for zero heat bits - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip atomic read-modify-write operations when a slot's heat bit is already clear. Reclaiming an unobserved cold mapping drops from four no-op RMWs to zero; actual clears retain
fetch_andunder the existing partition write guard to preserve neighboring slots in a shared bitmap word.Add shared-word concurrent-clear and slot-reuse regression coverage, and update the changelog.
Validation on macOS arm64:
cargo x check,cargo x test(372 Rust and 9 Python tests), andcargo x lintall passed, including dependency advisories. No throughput benchmark was run; the performance claim is limited to eliminating redundant atomic writes.