Repository navigation
perf: reuse validated payload checksums during reclaim - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hot-record reclaim validates the payload and then computes its CRC32C again while staging the rewrite. Carry the validated borrowed payload into staging to remove the second checksum pass. Key and value validation remains complete, and each replacement header gets its own checksum.
Keep regression coverage compact by reusing the existing staging fixture. A table-driven test covers corrupted keys and values, budget-skip accounting, padding-aware rewrite bytes, and readback after overwriting the source buffer; codec tests cover checksum validation and logical sequence preservation.
Validation on macOS:
cargo x check,cargo x test(371 Rust tests and 9 Python tests), andcargo x lint, including documentation, packaging, and dependency checks.