Container PyTest suite for Postgresql-container#640
Open
phracek wants to merge 22 commits intosclorg:masterfrom
Open
Container PyTest suite for Postgresql-container#640phracek wants to merge 22 commits intosclorg:masterfrom
phracek wants to merge 22 commits intosclorg:masterfrom
Conversation
Pull Request validationFailed🔴 Approval - missing or changes were requested Success🟢 CI - All checks have passed |
Member
Author
|
Let's try first round |
Testing Farm results
|
phracek
force-pushed
the
container_pytests
branch
from
d7126c2 to
a7a86fd
Compare
Member
Author
|
Let's try next round |
pkhartsk
requested changes
Jan 8, 2026
pkhartsk
requested changes
Jan 14, 2026
Contributor
pkhartsk
left a comment
pkhartsk
left a comment
There was a problem hiding this comment.
Found some things and included proposed fixes for both
Member
Author
|
I will rewrite it so that each commit will represent each test suite and ocp_renaming will be a part of another PR. |
phracek
force-pushed
the
container_pytests
branch
from
8f8b048 to
7eedd72
Compare
phracek
force-pushed
the
container_pytests
branch
from
f6fea7d to
b24e0a8
Compare
phracek
force-pushed
the
container_pytests
branch
from
b24e0a8 to
9a51951
Compare
phracek
force-pushed
the
container_pytests
branch
from
9a51951 to
c4921d6
Compare
Member
Author
|
@fila43 Please review parts |
fila43
reviewed
Mar 31, 2026
phracek
force-pushed
the
container_pytests
branch
from
6ae07ed to
5217d9d
Compare
Member
Author
|
Rebased against 'master' branch [test-pytest][test] |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
First few ideas.
Also, there are typos in commit messages: propoer instead of proper and test_container_generall.py instead of test_container_general.py
phracek
force-pushed
the
container_pytests
branch
from
5217d9d to
a116509
Compare
Member
Author
|
@frenzymadness Thanks for the second round of review. |
Member
Author
|
[test][test-pytest] |
frenzymadness
requested changes
Apr 21, 2026
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
Another run. If you know you are copy-pasting code or using the same patterns in multiple places, it would be nice to fix the issues I point out in a single place across all instances.
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_s2i_test -> test_container_basics.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_container_creation_tests -> test_container_configuration.py run_test_cfg_hook -> test_container_configuration.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_pgaudit_test -> test_container_extensions.py run_pgvector_test -> test_container_extensions.py run_env_extension_load_test -> test_container_extensions.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_general_tests -> test_container_general.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_logging_test -> test_container_logging.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_change_password_test -> test_container_password Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_replication_test -> test_container_replication.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
run_s2i_bake_data_test -> test_container_ssl.py run_s2i_enable_ssl_test -> test_container_ssl.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Test summary for version 16 ``` =========================== short test summary info ============================ PASSED test_container_migrate.py::TestPostgreSQLMigration::test_migration_functionality[13] PASSED test_container_migrate.py::TestPostgreSQLMigration::test_migration_functionality[15] SKIPPED [1] test_container_migrate.py:55: registry.redhat.io/rhel9/postgresql-12 image not found in registry so skipping migration test.. SKIPPED [1] test_container_migrate.py:51: Migration path from 16 -> 16 is not valid so skipping. SKIPPED [1] test_container_migrate.py:51: Migration path from 18 -> 16 is not valid so skipping. ``` Test summary for version 18 ``` =========================== short test summary info ============================ PASSED test_container_migrate.py::TestPostgreSQLMigration::test_migration_functionality[13] PASSED test_container_migrate.py::TestPostgreSQLMigration::test_migration_functionality[15] PASSED test_container_migrate.py::TestPostgreSQLMigration::test_migration_functionality[16] SKIPPED [1] test_container_migrate.py:55: registry.redhat.io/rhel9/postgresql-12 image not found in registry so skipping migration test.. SKIPPED [1] test_container_migrate.py:51: Migration path from 18 -> 18 is not valid so skipping. ``` Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Skip in case of previous version does not exist Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Sometimes /usr/libexec/check-container does not work properly. Let's check it by accepting connections by simple command Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Delete temporary directories at the end of each tests We do not need SSL warnings at all. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
We do not need 'none' in case 'version' exist in list then return index - 1 otherwise return None Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Update comment 4 in test_container_basics.py Remove obsoleted test, as it is not present in test/run_test bash tests as well. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Do not duplication code in case it is used at least twice Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
container_pytests
branch
from
d7d1382 to
57e09bc
Compare
Member
Author
|
[test-pytest] |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
One more round, and I hope we are done. This is mostly about comments and names, but the one about imports is important. There are also some open threads from previous rounds. I believe you can merge this once at least the imports are fixed.
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
Author
|
[test][test-pytest] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds PyTest suite migrated from
run_pytestscripts.All tests are migrated except
run_migration_testandrun_upgrade_test.