Repository navigation
fix/gradle: don't skip the Kotlin config export for cached compiles - #1059
Merged
Merged
Conversation
register a scipKotlinConfigs task instead and finalize Kotlin compiles with it. As it doesn't declare outputs Gradle runs it every time and never caches it. Kotlin compilation itself stays cacheable.
When a run reuses the configuration cache entry of an earlier run, the stored -randomtimestamp leaves compileJava up to date and no Java shards are written. This test fails until that is fixed. Amp-Thread-ID: https://ampcode.com/threads/T-01a1a699-5570-748e-af9d-6031d2964026 Co-authored-by: Amp <amp@ampcode.com>
The Gradle plugin isn't compatible with the configuration cache: scipPrintDependencies uses the project at execution time, and a reused entry keeps compileJava's random timestamp, leaving it up to date. The CLI now passes --no-configuration-cache after the build command, so it also overrides gradle.properties and a --configuration-cache in a custom build command.
This reverts commit e976e40. Not needed now that the CLI disables the configuration cache.
chrapkowski-sg
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register a scipKotlinConfigs task instead and finalize Kotlin compiles with it. As it doesn't declare outputs Gradle runs it every time and never caches it. Kotlin compilation itself stays cacheable.