Fix the ingestor not launching, and the workers crashing irrecoverably#52
Open
jnation3406 wants to merge 2 commits into
Open
Fix the ingestor not launching, and the workers crashing irrecoverably#52jnation3406 wants to merge 2 commits into
jnation3406 wants to merge 2 commits into
Conversation
Coverage Report for CI Build 28272900833Coverage remained the same at 91.477%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ingestor containers have never been running - they have just been using the entrypoint (wait_for_db.sh) which then launches gunicorn, so the command to run readstreams never happened. I've changed the script to allow the command override to be used.
Also, the dramatiq worker has been in a crash state on prod for a few weeks. I think the root cause is massive hangs/timeouts in the Rubin schedule call sometimes that caused the worker thread to be unresponsive and die. Hopefully adding request timeouts below that threshold will prevent their service timeouts from taking down the worker.