WIP: Add host galaxy spectrum download feature#437
Draft
dhvanildesai wants to merge 2 commits into
Draft
Conversation
Collaborator
|
A couple additional to-do things we discussed today: And future feature requests to enable spectra in blast will include: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #432
Summary
Adds host galaxy spectrum download functionality to the Blast pipeline. Archival spectra are fetched from SPARCL (DESI-DR1, SDSS-DR17, BOSS-DR17) with a NED fallback, stored as FITS files via a new
HostSpectrummodel. The downstream goal is to feed these spectra into STARLIGHT for stellar population fitting (something likeHostSpectrumFitting).Changes
New model:
HostSpectrumHostvia ForeignKeyNew pipeline:
fetch_host_spectrum()(app/host/host_spectrum.py)New task:
host_spectrum_downloadhost_informationand alongsidemwebv_host,global_aperture_construction,local_aperture_photometryWorkflow placement (feedback please)
Not sure if this is the right place in the chain — flagging for review.
Bug Fix
TaskLock name mismatch in
query_sdss()(app/host/host_utils.py)The SDSS query lock was being acquired under one name and released under a different one.
TaskLock.objects.release_lock('sdss_query')(lowercase)TaskLock.objects.release_lock('SDSS_query')(matches acquire)Next steps for me
full_devend-to-end testing (waiting for my new computer)