user-specified changes to transient, host, and aperture properties#430
user-specified changes to transient, host, and aperture properties#430djones1040 wants to merge 4 commits into
Conversation
|
@djones1040 Please update the changelog like I did in this PR so that it is easy to merge the changelog entries when we publish a new release. |
|
@djones1040 We should also have a corresponding unit test for this new feature. Take a look at this one I already made for the form that adds transients by definition. You could create a similar class method like |
fixed |
…ransients in the database were not handled properly
done, as ModifyTransientTest in test_views.py |
|
I'm seeing database transaction errors when I run the test, but they do not cause the new test to fail. In my experience after switching to PostgreSQL this indicates an actual logic error on our part, but since these are unit tests and it is not causing a failure I think we can ignore it until it causes a real problem. |
Fixes feature request #428. Adds a new option to the /add/ url where people can specify transient coords or redshifts, host coords or redshifts, and global aperture params. New database migration to support user comments and record which fields have been (most recently) updated by a user. Should probably also record which user did the changes but that's not implemented yet. Once updates have been added, task statuses are reset appropriately and the processing queue is re-triggered.
view of the /add/ page

view of the new form

Did all the testing I could think of and everything seems to work, though likely one or two bugs still lurking somewhere. Comments/suggestions welcome.