fixing aperture photometry bug for DES images#406
Conversation
|
There are lots of styling issues with the changes: excess indentation, trailing spaces, empty lines with only spaces, spaces missing or added where they shouldn't be around equal signs, insufficient newlines between functions or class methods. I use Flake8 and autopep8 extensions in VS Code to help me identify style violations. I'm going to push a code linting commit since most of it can be auto-corrected. 
|
| if not len(valid_urls): | ||
| return None | ||
| # we need both the depth and the image | ||
| time.sleep(1) |
There was a problem hiding this comment.
Why is there an artificial delay here?
There was a problem hiding this comment.
believe we found that these 1-second delays improved the success rate of the noirlab API in previous versions -- think this is basically inherited from previous versions
Change transient to 2026dgt Use multiprocessing for parallel downloads Discard data instead of writing to disk Do not fail when image is not available
|
@djones1040 Please review the update to the changelog and the version bump and update as needed. |
|
Actually wait on that. Your |
|
FYI the unit tests pass as off commit 0ec9eba |
believe that's in here https://github.com/scimma/blast/blob/djones-global-par/app/api/serializers.py line 21, unless you were the one who fixed that |
Right. When I made the first comment, the recent changes on main had not been merged into this feature branch you created beforehand. So I merged it in commit 9cd5209 before you looked at it. |
2 participants
Fixes #381 and #409. May also have improved robustness of DES downloads (I hope), at cost of a little more latency -- now checks across two versions and tries twice when URLs exist.
Description of the Change
Checklist
Please check all that apply to your proposed changes
Additional context