Repository navigation
feat(core-conan-hello): add Conan dependency provider sample - #86
Merged
Merged
Conversation
Uses cmake-conan's dependency provider via CMAKE_PROJECT_TOP_LEVEL_INCLUDES to get fmt from Conan during the CMake configure step. Assisted-by: ClaudeCode:claude-opus-5-5
for more information, see https://pre-commit.ci
henryiii
force-pushed
the
feat/core-conan-hello
branch
from
November 4, 2026 17:49
61b550c to
ffa80a3
Compare
Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Adds
core-conan-hello: a pybind11 module that getsfmtfrom Conan. It uses the cmake-conan dependency provider (conan_provider.cmake, copied fromdevelop2). scikit-build-core loads it throughcmake.define.CMAKE_PROJECT_TOP_LEVEL_INCLUDES, andconanis a build requirement. Conan runs during configure, so it uses the same compiler and build type as the rest of the build.The sample is added to the
distnox session and to the cibuildwheel matrix. It was built and tested locally on macOS arm64.Motivated by pypa/cibuildwheel#2564.