Repository navigation
feat: reserve tool entry key for build backends - #121
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Draft
A [[tool.dynamic-metadata]] entry may set config-settings, a table that maps plugin setting names to backend config-setting names. The loader validates it and removes it with provider, so a plugin never receives it. Assisted-by: ClaudeCode:claude-opus-5-5
henryiii
force-pushed
the
reserve-config-settings
branch
from
November 18, 2026 20:43
6b31cce to
36e5d1d
Compare
Assisted-by: ClaudeCode:claude-opus-5-5
Backends get per-entry tables under tool.<backend>, like the top-level tool table, so scikit-build-core uses tool.scikit-build.config-settings. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked this to be "tool", to keep it open for future additions. I like this much better than the specific
config-settings.🤖 AI text below 🤖
Reserves
toolin each[[tool.dynamic-metadata]]entry for build backends. Like the top-level[tool]table, it holds one table per backend, and each backend defines its own contents. For scikit-build/scikit-build-core#1632 this givestool.scikit-build.config-settings, which maps plugin settings to backend config-settings.tooltogether withprovider, so a plugin never receives it. The loader does not check its contents.toolto be a table.docs/backend_authors.md, with a note that loaders from before 0.7 pass the key through to the plugin.