Show the new code right after an authenticator is added - #461
Merged
Conversation
Whoever issued the QR code asks for a code straight away to confirm the device, so present the first one in a sheet before the add screen closes, and put new entries at the top of the vault instead of the bottom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a scan the app saved the entry and popped two screens at once, so the code needed to confirm the new device was never on screen. From the Authenticator list the new entry also landed at the bottom, because
TotpVault.addappended - you were scrolling to find it inside a 30-second window. From the connect-form picker no code was shown at all.A sheet now appears the moment an entry is saved, showing its live code with the countdown and a copy action, and new entries go to the top of the vault.
Not yet verified on a device: the backend stack was torn down, so the app cannot get past its loading screen to reach the Authenticator. The analyzer is clean and the release APK builds, but the sheet has not been seen rendering. Worth a look before this ships.
Closes #459