Drop comments that restate the code - #452
Merged
Merged
Conversation
Remove doc and inline comments that repeat the declaration below them. Keep the ones recording a decision: in-memory access tokens, the system-browser login, the http allowance for self-hosted backends, and the PageView carousel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
536 of 627 comment lines are gone across 44 Dart files, all of it commentary repeating the declaration underneath.
The 91 lines that stayed record decisions: the access token living in memory and being re-minted from the refresh token on cold start, login going through the system browser rather than a WebView, why
flutter_appauthis allowed plain http for a self-hosted backend, and the plainPageViewstanding in for a carousel Forui does not have.The generated client under
lib/api/, the gitignoredlib/l10n/app_localizations*.dart, and the workflow YAML were left alone.Verified that every non-comment line is byte-identical to before, that the five
// ignore:analyzer pragmas survive, and that no multi-line string contains a line that could have been mistaken for a comment.Closes #451