Redraw the app-modes diagram around the difference - #448
Merged
Conversation
Show the two paths converging on the same school system, with where the login and the data come to rest on each, instead of listing the client classes, and move the device-side details into prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old diagram had 16 nodes over three subgraphs and named the client classes, so it read as an inventory of the code rather than a picture of how the two modes differ - which is what the page and the table below it are about.
It is now seven nodes: both modes start with you, both end at your school's system, and what sits between them is the point. Account mode keeps a copy in Schuly's database; private mode keeps the login on your phone and the backend passes it straight through. Every arrow says what it carries.
The facts the old diagram was the only home for - the device keystore, the token and scrape strategies, on-device one-time codes, silent re-login on expiry - moved into a short prose section, where they read better than as edge labels.
Rendered through the real VitePress + mermaid pipeline to confirm it parses and lays out.
Closes #447