Repository navigation
feat(notifications): collapsible event-type filter row, collapsed by default (v2.39.1) - #200
Merged
Merged
Conversation
…default (v2.39.1) The inbox's event-type chips (one per notification type, 33 today) now sit in a collapsible "Type · 33" row that starts collapsed, so the inbox starts at the top. The open/closed choice (only that, never the selection) is remembered per browser under skilly.notifications.types-open. While collapsed with types selected, a "<k> selected · ✕ clear" summary keeps the filtered inbox explained and clearable. Reuses the shared CollapsibleFacetRow, which gains an optional collapsedSummary slot (rendered only while collapsed); the catalog and /requests rows are unchanged. Spec: SKILLY_SPEC.md §12 "Event-type filter (inbox)" + §10 shared-component note. Tests: facetRow unit test for the stored flag; notifications e2e for the full flow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Notifications page's event-type filter (one chip per type, 33 chips today) wrapped to about 9 lines and pushed the inbox below the fold. It is now a collapsible
TYPE · 33 ›row, collapsed by default.skilly.notifications.types-open("1"= open, anything else = collapsed). The type selection still lasts one visit.<k> selected · ✕ clearsits beside the header. While the row is open, the chips show the selection and✕ clearstays at the end of the chips, as before.How
CollapsibleFacetRow(catalog / Requested-skills Category row), which gets one optionalcollapsedSummaryslot. That slot renders in the chips column only while the row is collapsed. The catalog and/requestsdon't pass it, so they are unchanged. The chip block is now wrapped in a.facet-row-bodycolumn (min-width: 0).storedFlagOpen()inlib/facetRow.tsparses the stored flag. The key lives inlib/prefs.ts.Tests
facetRow.test.tscovers the own-key flag: only"1"is open; absent,"0"and junk values read as collapsed.notifications.spec.tswalks the full flow:pnpm typecheckpasses, and all 243 web unit tests pass. Bothnotifications.spec.tstests pass locally against the dev stack (no warm-up).Verified locally
In the browser on the dev stack:
Not in this PR
A pre-existing race in the inbox's
loadPage: a slow, supersededtypes=response can overwrite a newer one when chips are clicked quickly. Reproduced on a cold dev compile. Proposed as a separate fix.v2.39.1
🤖 Generated with Claude Code