Repository navigation
fix(dbtest): order the deprecation audit rows by seq, not a tied created_at - #199
Merged
Merged
Conversation
…ted_at setSkillDeprecation writes skill.deprecated and skill.unfeatured in one transaction, so both rows carry the same now() and `order by created_at` returned them in either order — Jenkins build 354 got them reversed. audit_log.seq (0008) is the monotonic append order; sort by it instead. Test-only, no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
§45 deprecationdbtest that failed on Jenkins (Deploy-Skilly #354):setSkillDeprecationwritesskill.deprecatedandskill.unfeaturedinside one transaction, so bothaudit_logrows get the samenow(). The test sorted them withorder by created_at, which is a tie, so Postgres could return them in either order. The test now sorts byaudit_log.seq(theBIGSERIALappend-order column from migration 0008, also used by the hash chain), which follows insert order.APP_VERSIONbump or changelog entry.audit_log … order by created_at. Each one either reads rows written by separate calls (so the timestamps differ) or finds rows by id, so none of them depend on order within one transaction.Verification
pnpm --filter @skilly/web typecheckdeprecation.dbtest.tsagainst a live DB: not run locally because the Docker engine was down. The CItest:dbstage on this PR is the check.🤖 Generated with Claude Code