Repository navigation
ci(e2e): parse the quick-run listing past pnpm's engine warning - #195
Merged
Merged
Conversation
ci/e2e-quick-list.mjs took the Playwright JSON report to start at the first `{` on
stdout. On an agent running Node 20 (the repo wants >=22) pnpm prints
`WARN Unsupported engine: wanted: {"node":">=22"} (current: ...)` to stdout first, so
the parse hit that line, the quick-list step crashed, and failFast aborted the other
Verify branches (the unit-test branch died mid content-risk.test.js with SIGTERM).
The report is now the first `{` from which the rest of stdout parses as one JSON
document; a listing with no report fails with a message that shows the output.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
A QUICK e2e build on Jenkins failed in its first seconds:
The script took the Playwright JSON report to start at the first
{on stdout. The agent runs Node 20.19.2 (.tool-versions) while the rootpackage.jsonwants>=22, so pnpm printsWARN Unsupported engine: wanted: {"node":">=22"} ...to stdout before the report, and the parse hit that line. BecauseVerifyisfailFast, Jenkins then SIGTERMed the sibling branches, which is why the unit-test branch showedcontent-risk.test.jsdying withsignal: 'SIGTERM'after 15 s. That test was collateral, not the cause.Fix
The report is now the first
{from which the rest of stdout parses as one JSON document. A listing with no report fails with a message that shows the output instead of a bareSyntaxError.Verified
node ci/e2e-quick-list.mjs <out>on the real suite: lists 211 tests and writes a 10% sample.CI-only change: no
APP_VERSIONbump, no changelog entry.🤖 Generated with Claude Code