Repository navigation
feat: normalize only : to only: in use statements - #14
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a0ccabbae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Closed
sbryngelson
force-pushed
the
normalize-only-colon
branch
from
September 16, 2026 04:31
4a0ccab to
802f32b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13 (independent; branched from master).
use m, only : aandONLY :now normalize toonly:/ONLY:(keyword case preserved, then handled bykeyword-caseas usual). Same shape as the existingintent (in)->intent(in)normalization: applies only on lines starting withuse, skips string literals and trailing comments, and leavesonly ::alone so a module namedm_onlyinuse m_only :: xis untouched.With
align-use-only(#13) this puts the colon in one column as well as theo.Also documents that
align-assignments = "preserve"does not retain existing manual padding, sincecollapse-double-spacesand whitespace normalization still run.Tests: 6 unit tests in
tests/whitespace.rs, 1 end-to-end intests/config_integration.rs.