Skip to content

feat: normalize only : to only: in use statements - #14

Merged
sbryngelson merged 1 commit into
masterfrom
normalize-only-colon
Sep 16, 2026
Merged

sbryngelson merged 1 commit into
masterfrom
normalize-only-colon

Conversation

@sbryngelson

Copy link
Copy Markdown
Owner

Follow-up to #13 (independent; branched from master).

use m, only : a and ONLY : now normalize to only: / ONLY: (keyword case preserved, then handled by keyword-case as usual). Same shape as the existing intent (in) -> intent(in) normalization: applies only on lines starting with use, skips string literals and trailing comments, and leaves only :: alone so a module named m_only in use m_only :: x is untouched.

With align-use-only (#13) this puts the colon in one column as well as the o.

Also documents that align-assignments = "preserve" does not retain existing manual padding, since collapse-double-spaces and whitespace normalization still run.

Tests: 6 unit tests in tests/whitespace.rs, 1 end-to-end in tests/config_integration.rs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T03:20:44.251601Z 4a0ccab PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a0ccabbae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/whitespace.rs Resolved
@sbryngelson
sbryngelson merged commit 21fbf07 into master Sep 16, 2026
9 checks passed
@sbryngelson
sbryngelson deleted the normalize-only-colon branch September 16, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant