Skip to content

fix: docs and input checks of the CNN and permutation-invariant embedding nets - #2113

Open
janfb wants to merge 13 commits into
mainfrom
docs-cnn-embedding-args
Open

janfb wants to merge 13 commits into
mainfrom
docs-cnn-embedding-args

Merge remote-tracking branch 'origin/main' into docs-cnn-embedding-args

9118297
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2026 in 1s

91.16% (target 70.00%)

View this Pull Request on Codecov

91.16% (target 70.00%)

Details

Codecov Report

❌ Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.16%. Comparing base (c36f471) to head (9118297).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sbi/neural_nets/embedding_nets/causal_cnn.py 70.83% 7 Missing ⚠️
sbi/neural_nets/embedding_nets/lru.py 0.00% 2 Missing ⚠️
sbi/neural_nets/embedding_nets/SC_embedding.py 50.00% 1 Missing ⚠️
sbi/neural_nets/embedding_nets/cnn.py 91.66% 1 Missing ⚠️
...eural_nets/embedding_nets/permutation_invariant.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2113    +/-   ##
========================================
  Coverage   91.15%   91.16%            
========================================
  Files         142      142            
  Lines       14884    15194   +310     
========================================
+ Hits        13568    13851   +283     
- Misses       1316     1343    +27     
Files with missing lines Coverage Δ
sbi/neural_nets/embedding_nets/SC_embedding.py 91.83% <50.00%> (-0.95%) ⬇️
sbi/neural_nets/embedding_nets/cnn.py 98.33% <91.66%> (-1.67%) ⬇️
...eural_nets/embedding_nets/permutation_invariant.py 97.91% <85.71%> (-2.09%) ⬇️
sbi/neural_nets/embedding_nets/lru.py 93.24% <0.00%> (-0.64%) ⬇️
sbi/neural_nets/embedding_nets/causal_cnn.py 83.52% <70.83%> (-4.15%) ⬇️

... and 3 files with indirect coverage changes