Repository navigation
feat(model): make HF smoke latency comparisons output-length aware - #178
Merged
sanskarIN merged 7 commits intoOct 30, 2026
Merged
Conversation
…t persisting source
…nders in HF comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Raw base-versus-LoRA generation latency is misleading when the two models emit different output lengths. The optional local HF smoke currently reports timing but not actual generated-token counts, so a slower model could simply be generating more tokens.
Changes
lineloom-hf-synthetic-smoke-v5and comparison tolineloom-hf-synthetic-comparison-v4.model.generate(); never persist decoded code, token IDs, per-case lengths, prompts or paths.generatedTokenCountand five-languagegeneratedTokensByLanguage, alongside existing p50/p95 generation-only timings.DIFFERENT_GENERATED_TOKEN_TOTALS/AGGREGATE_TOKEN_TOTALS_MATCH_ONLY. Even equal aggregate counts do not prove per-case length parity or hardware parity.model/EVALUATION_PROTOCOL.mdandmodel/train/README.md.Safety and release boundaries