Initial refactoring - #3

Open

JonahHouseKin wants to merge 285 commits into

sandimetz:mainfrom

JonahHouseKin:refactoring-example

This pull request is big! We're only showing the most recent 250 commits

Commits on Oct 12, 2020

song test #3-just write it down

skmetz
authored and
Katrina Owen
committed
0ca6862
add case 6/7 to verse

skmetz
authored and
Katrina Owen
committed
8fbc519
revert case 6/7

skmetz
authored and
Katrina Owen
committed
5cdb6b1
interpolate number in 2 case

skmetz
authored and
Katrina Owen
committed
8bbdda7
fling entire container method in

skmetz
authored and
Katrina Owen
committed
6472691
revert prior change

skmetz
authored and
Katrina Owen
committed
bcf2570
add empty container method

skmetz
authored and
Katrina Owen
committed
8bf693d
return 'bottles' in container

skmetz
authored and
Katrina Owen
committed
2ffce1e
send #container in default

skmetz
authored and
Katrina Owen
committed
1ce89b7
add defaulted arg to container

skmetz
authored and
Katrina Owen
committed
8bbad05
add entire conditional to container

skmetz
authored and
Katrina Owen
committed
30f83f4
pass arg when sending #container

skmetz
authored and
Katrina Owen
committed
103e78d
use #container in 2 case

skmetz
authored and
Katrina Owen
committed
a27d249
remove obsolete default arg

skmetz
authored and
Katrina Owen
committed
bb70758
delete obsolete 2 case

skmetz
authored and
Katrina Owen
committed
c557716
interpolate number at start of 1 case

skmetz
authored and
Katrina Owen
committed
acc5aea
send #container in phrase 1 case 1

skmetz
authored and
Katrina Owen
committed
70a1d30
make phrase 1/2 of case 1/else identical

skmetz
authored and
Katrina Owen
committed
821013c
add pronoun

skmetz
authored and
Katrina Owen
committed
bef2d99
pronoun returns 'one'

skmetz
authored and
Katrina Owen
committed
ab7f687
send pronoun in else

skmetz
authored and
Katrina Owen
committed
dc3c163
add defaulted arg to pronoun

skmetz
authored and
Katrina Owen
committed
008ec30
use pronoun arg in if statement

skmetz
authored and
Katrina Owen
committed
ebb9f06
pass arg to pronoun in else

skmetz
authored and
Katrina Owen
committed
8be9e2e
use pronoun arg in 1 case

skmetz
authored and
Katrina Owen
committed
0092a4f
remove obsolete arg from pronoun

skmetz
authored and
Katrina Owen
committed
d7e7407
add quantity

skmetz
authored and
Katrina Owen
committed
12ecb9b
quantity returns 'no more'

skmetz
authored and
Katrina Owen
committed
e7914ac
1 case sends quantity

skmetz
authored and
Katrina Owen
committed
9ce9cb7
add arg and wrong default to quantity

skmetz
authored and
Katrina Owen
committed
66721ac
use wrong default in quantity conditional

skmetz
authored and
Katrina Owen
committed
d5610c9
revert to green

skmetz
authored and
Katrina Owen
committed
ad81c88
set quantity arg default to correct value

skmetz
authored and
Katrina Owen
committed
b8e4da6
use correct default in quantity conditional

skmetz
authored and
Katrina Owen
committed
3af4d67
send quantity(arg) in case 1 phrase 4

skmetz
authored and
Katrina Owen
committed
a7d9f5d
send quantity(arg) in else phrase 4

skmetz
authored and
Katrina Owen
committed
e81781a
remove obsolete default

skmetz
authored and
Katrina Owen
committed
50742cd
send container in case 1 phrase 4

skmetz
authored and
Katrina Owen
committed
3eaf43f
delete case 1

skmetz
authored and
Katrina Owen
committed
3200230
send quantity in case 0 phrase 1

skmetz
authored and
Katrina Owen
committed
97a6894
send quantity in else phrase 1, FAILS

skmetz
authored and
Katrina Owen
committed
40abbcf
hack to_s in else case to sidestep error

skmetz
authored and
Katrina Owen
committed
557aec5
add unneeded to_s to 1 case to make them the same

skmetz
authored and
Katrina Owen
committed
6ff0514
add to_s to #quantity, return a capitalizable

skmetz
authored and
Katrina Owen
committed
78194c5
remove obsolete to_s's

skmetz
authored and
Katrina Owen
committed
b1a6915
send container in case 0 phrase 1

skmetz
authored and
Katrina Owen
committed
e996aef
send quantity in else phrase 2

skmetz
authored and
Katrina Owen
committed
7c03081
make case 0 phrase 2 like else phrase 2

skmetz
authored and
Katrina Owen
committed
20785df
add complete #action

skmetz
authored and
Katrina Owen
committed
1144261
use #action

skmetz
authored and
Katrina Owen
committed
e7b14e3
send #quantity(99)

skmetz
authored and
Katrina Owen
committed
9434089
send container in case 0 phrase 4

skmetz
authored and
Katrina Owen
committed
1fb7d1f
add #successor(number)

skmetz
authored and
Katrina Owen
committed
61ad1c5
send #successor in else phrase 4

skmetz
authored and
Katrina Owen
committed
f9fa810
add conditional to #successor

skmetz
authored and
Katrina Owen
committed
c3132b8
replace 99 with successor(number)

skmetz
authored and
Katrina Owen
committed
9cbd3b8
use successor everywhere

skmetz
authored and
Katrina Owen
committed
37ce41f
try common template

skmetz
authored and
Katrina Owen
committed
f98d9d8
delete obsolete code

skmetz
authored and
Katrina Owen
committed
2fa7d05
wrap long lines in verse

skmetz
authored and
Katrina Owen
committed
89a4874
add empty BottleNumber class

skmetz
authored and
Katrina Owen
committed
a3214ee
copy obsessive methods to BottleNumber

skmetz
authored and
Katrina Owen
committed
f6e5a12
add attr_reader and initializer

skmetz
authored and
Katrina Owen
committed
a504be3
parse/exec BottleNumber#quantity

skmetz
authored and
Katrina Owen
committed
0052ae4
use BottleNumber#quantity result

skmetz
authored and
Katrina Owen
committed
08ce5ca
delete obsolete code

skmetz
authored and
Katrina Owen
committed
1456e3d
parse/exec BottleNumber#container

skmetz
authored and
Katrina Owen
committed
3e4f06a
use BottleNumber#container result

skmetz
authored and
Katrina Owen
committed
f8e6cad
delete obsolete code

skmetz
authored and
Katrina Owen
committed
fc3a435
parse/exec BottleNumber#action

skmetz
authored and
Katrina Owen
committed
52e384c
use BottleNumber#action result

skmetz
authored and
Katrina Owen
committed
b43f221
delete obsolete code

skmetz
authored and
Katrina Owen
committed
8ee2229
parse/exec BottleNumber#pronoun

skmetz
authored and
Katrina Owen
committed
bf42aa3
use BottleNumber#pronoun result

skmetz
authored and
Katrina Owen
committed
d764d71
delete obsolete code

skmetz
authored and
Katrina Owen
committed
e20667d
parse/exec BottleNumber#successor

skmetz
authored and
Katrina Owen
committed
70f4cba
use BottleNumber#successor result

skmetz
authored and
Katrina Owen
committed
6c2d3c4
delete obsolete code

skmetz
authored and
Katrina Owen
committed
cb95f42
rename BottleNumber#quantity argument

skmetz
authored and
Katrina Owen
committed
d3be56c
remove param from sender

skmetz
authored and
Katrina Owen
committed
3b4c7c7
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
8f2e7c1
rename BottleNumber#container argument

skmetz
authored and
Katrina Owen
committed
185c027
remove param from sender

skmetz
authored and
Katrina Owen
committed
72f88ac
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
62b1d14
rename BottleNumber#action argument

skmetz
authored and
Katrina Owen
committed
9517843
remove param from sender

skmetz
authored and
Katrina Owen
committed
79caa4f
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
538dcd3
rename BottleNumber#pronoun argument

skmetz
authored and
Katrina Owen
committed
61f863d
remove param from unused sender

skmetz
authored and
Katrina Owen
committed
d9f0321
remove arg from receiver FAIL

skmetz
authored and
Katrina Owen
committed
fb2bc41
revert prior change

skmetz
authored and
Katrina Owen
committed
eaad2d1
delete unused Bottles#pronoun

skmetz
authored and
Katrina Owen
committed
630c8d9
remove param from sender

skmetz
authored and
Katrina Owen
committed
461ed1f
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
7d01c25
rename BottleNumber#successor argument

skmetz
authored and
Katrina Owen
committed
32879ab
remove param from sender

skmetz
authored and
Katrina Owen
committed
c2f1969
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
a95fde7
cache (memoize) a BottleNumber

skmetz
authored and
Katrina Owen
committed
3437f44
send #action to bottle_number

skmetz
authored and
Katrina Owen
committed
4725db6
use bottle_number is phrase 1

skmetz
authored and
Katrina Owen
committed
516815e
use bottle_number is phrase 2

skmetz
authored and
Katrina Owen
committed
6fd6864
cache (memoize) the next BottleNumber

skmetz
authored and
Katrina Owen
committed
0c87e3f
use next_bottle_number is phrase 4

skmetz
authored and
Katrina Owen
committed
ed83d22
delete obsolete code

skmetz
authored and
Katrina Owen
committed
24cd637
add BottleNumber#to_s

skmetz
authored and
Katrina Owen
committed
f52bff9
use to_s in phrase 1

skmetz
authored and
Katrina Owen
committed
8f8a6fa
use to_s in phrase 2

skmetz
authored and
Katrina Owen
committed
5d8ec82
use to_s in phrase 4

skmetz
authored and
Katrina Owen
committed
e17527e
unite phrase 1 on single line

skmetz
authored and
Katrina Owen
committed
7f4a20e
consolidate phrase 1 strings

skmetz
authored and
Katrina Owen
committed
221ca49
unite phrase 4 on single line

skmetz
authored and
Katrina Owen
committed
5697969
consolidate phrase 4 strings

skmetz
authored and
Katrina Owen
committed
0788ebb
create BottleNumber0 class

skmetz
authored and
Katrina Owen
committed
5af6dc5
copy #quantity to BottleNumber0

skmetz
authored and
Katrina Owen
committed
1bbb637
reduce #quantity to specialization

skmetz
authored and
Katrina Owen
committed
2560fde
add #bottle_number_for

skmetz
authored and
Katrina Owen
committed
5a4b552
use #bottle_number_for once

skmetz
authored and
Katrina Owen
committed
f74faa7
use #bottle_number_for twice

skmetz
authored and
Katrina Owen
committed
1bf280f
manufacture a bottle number

skmetz
authored and
Katrina Owen
committed
92b0eb0
parse an alternate factory impl

skmetz
authored and
Katrina Owen
committed
b5ce952
use the alternate implementation

skmetz
authored and
Katrina Owen
committed
ccf8a14
reduce super #quantity to generalization

skmetz
authored and
Katrina Owen
committed
cf4c4e0
copy #action to BottleNumber0

skmetz
authored and
Katrina Owen
committed
e0dd252
return specialization

skmetz
authored and
Katrina Owen
committed
092f8ff
delete obsolete code

skmetz
authored and
Katrina Owen
committed
8b5f746
return super's generalization

skmetz
authored and
Katrina Owen
committed
aa8f07c
delete obsolete code

skmetz
authored and
Katrina Owen
committed
b6fdef9
copy #successor to BottleNumber0

skmetz
authored and
Katrina Owen
committed
b4d21fa
return specialization

skmetz
authored and
Katrina Owen
committed
e6da42d
delete obsolete code

skmetz
authored and
Katrina Owen
committed
1add2f0
return super's generalization

skmetz
authored and
Katrina Owen
committed
6b84117
delete obsolete code

skmetz
authored and
Katrina Owen
committed
dc8f6f0
create BottleNumber1 class

skmetz
authored and
Katrina Owen
committed
9d33dc3
copy #container to BottleNumber1

skmetz
authored and
Katrina Owen
committed
2016970
return specialization

skmetz
authored and
Katrina Owen
committed
4911a71
delete obsolete code

skmetz
authored and
Katrina Owen
committed
4d3c261
return super's generalization FAIL

skmetz
authored and
Katrina Owen
committed
186c5d3
revert previous change

skmetz
authored and
Katrina Owen
committed
fe798c1
parse updated factory

skmetz
authored and
Katrina Owen
committed
59c082e
use updated factory

skmetz
authored and
Katrina Owen
committed
ff6ec76
return super's #container generalization

skmetz
authored and
Katrina Owen
committed
9f65bc2
delete obsolete code

skmetz
authored and
Katrina Owen
committed
45ecfe5
copy #pronoun to BottleNumber1

skmetz
authored and
Katrina Owen
committed
2513f12
return specialization

skmetz
authored and
Katrina Owen
committed
c1fb91a
return super's generalization

skmetz
authored and
Katrina Owen
committed
3769e8e
delete obsolete code

skmetz
authored and
Katrina Owen
committed
6ff93e1
wish for a smarter successor

skmetz
authored and
Katrina Owen
committed
796af14
copy #bottle_number_for to BottleNumber.for

skmetz
authored and
Katrina Owen
committed
6df27d9
use .for factory once

skmetz
authored and
Katrina Owen
committed
d7a5902
use .for factory twice

skmetz
authored and
Katrina Owen
committed
65b3382
delete obsolete code

skmetz
authored and
Katrina Owen
committed
6e56684
add type check guard clause to BottleNumber.for

skmetz
authored and
Katrina Owen
committed
eb3fdfe
return a bottle number from BottleNumber0#successor

skmetz
authored and
Katrina Owen
committed
887c43b
return a bottle number from BottleNumber#successor

skmetz
authored and
Katrina Owen
committed
6047d03
see if the successor wish now works

skmetz
authored and
Katrina Owen
committed
da026bf
delete obsolete code

skmetz
authored and
Katrina Owen
committed
6f1be7e
inline next_bottle_number temp

skmetz
authored and
Katrina Owen
committed
bc631cd
delete obsolete code

skmetz
authored and
Katrina Owen
committed
c096ebf
delete obsolete code

skmetz
authored and
Katrina Owen
committed
1231ac9
add six-pack to song test

skmetz
authored and
Katrina Owen
committed
7c6e55a
create BottleNumber6 class

skmetz
authored and
Katrina Owen
committed
e14ef35
add BottleNumber6#container

skmetz
authored and
Katrina Owen
committed
9fd416b
add BottleNumber6 to factory

skmetz
authored and
Katrina Owen
committed
5cb00be
add BottleNumber6#quantity

skmetz
authored and
Katrina Owen
committed
2e7f20c
parse metaprogrammed factory

skmetz
authored and
Katrina Owen
committed
aef5a8f
use metaprogrammed factory

skmetz
authored and
Katrina Owen
committed
010e4a9
parse Hash factory

skmetz
authored and
Katrina Owen
committed
30b6bcc
use Hash factory

skmetz
authored and
Katrina Owen
committed
5191ef7
add handles? method to BottleNumber6

skmetz
authored and
Katrina Owen
committed
110c9a1
add handles? method to BottleNumber1

skmetz
authored and
Katrina Owen
committed
acd1b26
add handles? method to BottleNumber0

skmetz
authored and
Katrina Owen
committed
d5f88ac
add handles? method to BottleNumber

skmetz
authored and
Katrina Owen
committed
3e87528
parse dispersed choosing logic factory

skmetz
authored and
Katrina Owen
committed
256209a
use dispersed choosing logic factory

skmetz
authored and
Katrina Owen
committed
b4547c1
add BottleNumber.registry

skmetz
authored and
Katrina Owen
committed
c6b43f5
add BottleNumber.register

skmetz
authored and
Katrina Owen
committed
17eb5ec
register BottleNumber6

skmetz
authored and
Katrina Owen
committed
c289215
register BottleNumber1

skmetz
authored and
Katrina Owen
committed
b84bb4c
register BottleNumber0

skmetz
authored and
Katrina Owen
committed
125c2ce
register BottleNumber

skmetz
authored and
Katrina Owen
committed
041d86e
parse self registering factory

skmetz
authored and
Katrina Owen
committed
5844efa
use self registering factory

skmetz
authored and
Katrina Owen
committed
d314080
override inherited hook

skmetz
authored and
Katrina Owen
committed
dcd89fa
delete obsolete code

skmetz
authored and
Katrina Owen
committed
6a30763
initialize registry with BottleNumber

skmetz
authored and
Katrina Owen
committed
ef3b303
delete obsolete code

skmetz
authored and
Katrina Owen
committed
e2705c2
revert to simplest factory

skmetz
authored and
Katrina Owen
committed
80a299e
create BottleVerse class

skmetz
authored and
Katrina Owen
committed
e197539
add attr_reader and initialize number

skmetz
authored and
Katrina Owen
committed
05271ab
copy #verse from Bottles to BottleVerse

skmetz
authored and
Katrina Owen
committed
5809b5f
parse/exec new #verse from old #verse

skmetz
authored and
Katrina Owen
committed
0b4fc0b
use result of new #verse

skmetz
authored and
Katrina Owen
committed
a6fa17f
revert to old #verse

skmetz
authored and
Katrina Owen
committed
5500fad
wish to send #lyrics

skmetz
authored and
Katrina Owen
committed
a093565
change BottleVerse#verse(number) to BottleVerse#lyrics

skmetz
authored and
Katrina Owen
committed
51cd64f
parse/exec sending #lyrics

skmetz
authored and
Katrina Owen
committed
8d6c5e2
use result of sending #lyrics

skmetz
authored and
Katrina Owen
committed
d0131e9
wish to depend of verse template role

skmetz
authored and
Katrina Owen
committed
806010f
inject verse_template role

skmetz
authored and
Katrina Owen
committed
1c8cb79
use result from verse template role

skmetz
authored and
Katrina Owen
committed
84b7470
wish for lyrics without Demeter violation

skmetz
authored and
Katrina Owen
committed
0645b1d
add BottleVerse.lyrics to make wish possible

skmetz
authored and
Katrina Owen
committed
b1d8df7
retrieve lyrics without Demeter violation

skmetz
authored and
Katrina Owen
committed
6a7c11b
wish to consolidate object creation

skmetz
authored and
Katrina Owen
committed
13ac11a
lyrics works with numbers or bottle numbers

skmetz
authored and
Katrina Owen
committed
37b5bd7
parse/exec wish

skmetz
authored and
Katrina Owen
committed
e50aef8
use result of consolidated object creation wish

skmetz
authored and
Katrina Owen
committed
18be38b
remove number to bottle number conversion from #lyrics

skmetz
authored and
Katrina Owen
committed
16cf1cc
add bottle_number attr_reader

skmetz
authored and
Katrina Owen
committed
4ecee97
initialize bottle_number

skmetz
authored and
Katrina Owen
committed
7f9ffca
delete obsolete code

skmetz
authored and
Katrina Owen
committed
311964a
add alternate initializer

skmetz
authored and
Katrina Owen
committed
df2001d
use alternate initializer

skmetz
authored and
Katrina Owen
committed
dcfee21
delete obsolete code

skmetz
authored and
Katrina Owen
committed
2e6bdd2
add BottleVerseTest

skmetz
authored and
Katrina Owen
committed
01e9e91
copy 1st test from BottlesTest to BottleVerseTest

skmetz
authored and
Katrina Owen
committed
a4c95cb
use BottleVerse in 1st test

skmetz
authored and
Katrina Owen
committed
3d951cc
delete obsolete test

skmetz
authored and
Katrina Owen
committed
c26aa74
copy all other verse tests into BottleVerseTest

skmetz
authored and
Katrina Owen
committed
f6500a3
make 1 undo regexp change from Bottles to BottleVerse

skmetz
authored and
Katrina Owen
committed
0daf8e5
delete obsolete test

skmetz
authored and
Katrina Owen
committed
f486a9d
rename lower bound test

skmetz
authored and
Katrina Owen
committed
11a76e5
rename upper bound test

skmetz
authored and
Katrina Owen
committed
1b0fb4b
add verse 7 test

skmetz
authored and
Katrina Owen
committed
8cee690
add verse 6 test

skmetz
authored and
Katrina Owen
committed
5a607bd
duplicate Bottles as CountdownSong

skmetz
authored and
Katrina Owen
committed
2a1343f
change BottlesTest to CountdownSongTest

skmetz
authored and
Katrina Owen
committed
97c47d4
change Bottles to CountdownSong (1 undo change)

skmetz
authored and
Katrina Owen
committed
7be7c1a
delete obsolete Bottles class

skmetz
authored and
Katrina Owen
committed
6dcd624
add VerseFake

skmetz
authored and
Katrina Owen
committed
fed47c5
create alternate test_a_couple_verses method

skmetz
authored and
Katrina Owen
committed
9a0a0ba
use VerseFake in alternate couple_verses test

skmetz
authored and
Katrina Owen
committed
c23fd06
delete obsolete test

skmetz
authored and
Katrina Owen
committed
2fadf4d
delete redundant test_a_few_verses

skmetz
authored and
Katrina Owen
committed
e34d2ac
add verse test

skmetz
authored and
Katrina Owen
committed
3c27f0a
rename verses test

skmetz
authored and
Katrina Owen
committed
bd0ebf3
create max and min attr_readers

skmetz
authored and
Katrina Owen
committed
d034b91
initialize max and min

skmetz
authored and
Katrina Owen
committed
650cbdd
use max and min in #song

skmetz
authored and
Katrina Owen
committed
db9d103
add alternate #test_the_whole_song

skmetz
authored and
Katrina Owen
committed
413d9dc
delete obsolete test

skmetz
authored and
Katrina Owen
committed
1ce274b
rename song test

skmetz
authored and
Katrina Owen
committed
0ec49e9
move VerseFake to top of file

skmetz
authored and
Katrina Owen
committed
ff4f96c
add verse role test

skmetz
authored and
Katrina Owen
committed
b8b6864
set @role_player in BotttleVerseTest#setup

skmetz
authored and
Katrina Owen
committed
6650516
include VerseRoleTest in BottleVerseTest

skmetz
authored and
Katrina Owen
committed
cc55fae
create VerseFakeTest

skmetz
authored and
Katrina Owen
committed
4eb1c60
remove verse_template default

skmetz
authored and
Katrina Owen
committed
21affb8
set max default to 999999

skmetz
authored and
Katrina Owen
committed
4d130d6

Commits on Jan 20, 2024

Initial refactoring
JonahHouseKin
committed
7aaed88