Skip to content

chore: migrate to busted api - #29

Merged
sand4rt merged 4 commits into
mainfrom
migrate-to-busted
Sep 24, 2026
Merged

sand4rt merged 4 commits into
mainfrom
migrate-to-busted

Conversation

@sand4rt

@sand4rt sand4rt commented Sep 24, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 24, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed changes preserve existing coverage and have no unresolved blocking issues.

Review effort: Lite
Findings: None

What changed in this PR

Migrates the test suite from MiniTest set registration to Busted-style APIs.

Changes:

  • Converts tests to describe/it blocks and lifecycle hooks.
  • Enables Busted API emulation in the test bootstrap.
  • Preserves existing test coverage.
File Description
tests/​test_tabs.lua Migrates tab tests.
tests/​test_splits.lua Migrates split tests.
tests/​test_resizing.lua Migrates resizing tests.
tests/​test_integrations.lua Migrates integration tests.
tests/​test_autocmd.lua Migrates autocmd tests.
tests/​scripts/​minimal_init.lua Enables Busted-style collection.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sand4rt

sand4rt commented Sep 24, 2026

Copy link
Copy Markdown
Owner Author

@copilot please fix the merge conflicts in this pull request.

Copilot AI and others added 2 commits September 24, 2026 13:20
# Conflicts:
#	tests/test_splits.lua

Co-authored-by: sand4rt <17591696+sand4rt@users.noreply.github.com>
Co-authored-by: sand4rt <17591696+sand4rt@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 24, 2026 13:21
Co-authored-by: sand4rt <17591696+sand4rt@users.noreply.github.com>

Copilot AI commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@copilot please fix the merge conflicts in this pull request.

Done — I merged main into this branch, resolved the conflicts, and pushed the fix in commit cdaf669.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Copilot AI review requested due to automatic review settings September 24, 2026 13:24
@sand4rt
sand4rt merged commit 48b408b into main Sep 24, 2026
2 checks passed
@sand4rt
sand4rt deleted the migrate-to-busted branch September 24, 2026 13:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Restore the creation guard on all exit paths to prevent subsequent user splits from being skipped.

Review effort: Lite
Findings: None

Previously missed (1)

In code that hasn't changed since last review

Medium severity Reset window creation guard when create_window errors

lua/​zen/​init.lua:48

This flag is cleared only on the successful path through create_window. If vnew, a window option update, or a buffer option update raises, it remains true; every subsequent WinNew callback then returns at line 571, so normal user splits stop closing the side buffers. Restore the flag in protected cleanup (for example, an xpcall/finally-style wrapper) on all exits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants