Repository navigation
fix(chart): serve the autoscaler from autoscaling/v2 - #177
Merged
Merged
Conversation
The chart rendered its HorizontalPodAutoscaler as autoscaling/v2beta1, which Kubernetes stopped serving in 1.25. Chart.yaml requires 1.27 or later, so an install with autoscaling.enabled set to true failed on every cluster the chart supports. The template now renders autoscaling/v2, with each target as a Utilization type. - templates/hpa.yaml moves the CPU and memory targets under target. - An install with autoscaling on creates the autoscaler, where 0.3.3 fails with no matches for kind HorizontalPodAutoscaler.
The chart README came from helm-docs at chart 0.2.10 and described values that have changed since. The Charts workflow copies the root README over it before each release, so no published chart carried it. Readers find the values in values.yaml and on the docs site. - charts/reverse-geocoding/README.md goes. - A package built the way the release builds it carries the root README.
Chart 0.3.4 carries the autoscaling/v2 template. Chart-testing expects a higher version for any change under charts/, and appVersion follows the version through the YAML anchor. - Chart.yaml sets version 0.3.4. - The chart lints cleanly at the new version.
1 task done
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chart renders its HorizontalPodAutoscaler as
autoscaling/v2, soautoscaling.enabled=trueinstalls on the Kubernetes versions the chart supports. The stale helm-docs README leaves the chart directory, and the chart version moves to 0.3.4.Related Issues
Fixes #176.
Changes Made
targetwithtype: Utilization, the shapeautoscaling/v2takes.main.Testing
helm lint- passes at 0.3.4helm install --set autoscaling.enabled=trueon Kubernetes 1.37 in kind - creates the autoscaler, where chart 0.3.3 fails withno matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"helm test-Succeededhelm packageafter the release step's README copy - the package holds the root READMEChecklist
Chart.yamlraises the version to 0.3.4