Repository navigation
test: check that stream is a resource in testSendConnectionAborted - #299
Merged
phil-davis merged 1 commit intoOct 22, 2026
Merged
phil-davis merged 1 commit into
phil-davis merged 1 commit into
Conversation
If phpunit is run locally without having started a test server, then an error is reported from fread about stream being false. This change makes the result a bit nicer. If the fopen does not succeed then the test fails early and reports a hopefully-useful message. Signed-off-by: Phillip Davis <phil@jankaritech.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
=========================================
Coverage 94.81% 94.81%
Complexity 258 258
=========================================
Files 15 15
Lines 849 849
=========================================
Hits 805 805
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If phpunit is run locally without having started a test server, then an error is reported from fread about stream being false.
This change makes the result a bit nicer. If the fopen does not succeed then the test fails early and reports a hopefully-useful message.