feat(agent-history): add Antigravity CLI (agy) history reader - #2
feat(agent-history): add Antigravity CLI (agy) history reader#2dorokuma wants to merge 3 commits into
Conversation
ryonakae
left a comment
There was a problem hiding this comment.
Thanks for working on Antigravity history support. I verified that the agy agent name and herdr:antigravity_cli session source match Herdr's integration, and this would be a useful addition to Shepherd.
I found a few correctness issues that should be addressed before merging:
-
PLANNER_RESPONSE.tool_calls[].argsis currently emitted as atool_result. These are tool inputs, not execution results. Actual results appear in separate transcript entries such asLIST_DIRECTORY. This can makeagent read,lastToolResult, and wake notifications report incorrect information. Please parse actual result entries, or omit tool results when they cannot be represented correctly. Tests should cover actual output, errors, and multiple tool calls. -
When
conversation_summaries.dbis missing or unreadable, discovery falls back to the newest transcript across the entire brain directory. Since these transcripts do not contain a cwd, this can attribute a conversation from another workspace to the current agent. Please fail closed in this case: returning no history is preferable to returning another agent's history. -
Workspace URI matching currently accepts parent/child relationships in both directions and treats
/as matching everything. This can mix root and subproject conversations. Please use proper file URI/path normalization and restrict matching to an unambiguous relationship.
Please also update the supported-agent list in README.md and README.ja.md.
The overall feature is worth merging; these are correctness issues rather than a rejection of the approach. I'll be happy to review an updated version.
What
Adds an AgentHistoryReader for Antigravity CLI (agy), so Shepherd can surface the last assistant message for agy agents managed through Herdr (agent_session refs with source herdr:antigravity_cli previously resolved to unknown, leaving wake summaries empty).
How
Testing
Note: agy transcripts do not embed a cwd; directory auto-discovery matches the agent's cwd against conversation_summaries.db when available and falls back to the newest transcript otherwise.