Skip to content

fix: ui overflow #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirily11 merged 1 commit into from
Sep 28, 2026
Merged

fix: ui overflow #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion RxCode/Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,7 @@
}
},
"7-day only" : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -10497,6 +10498,7 @@
}
},
"Filter" : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -11763,6 +11765,7 @@
}
},
"Hover" : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -13042,6 +13045,7 @@
}
},
"Line" : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -16866,6 +16870,7 @@
}
},
"One provider's limit. Its height is the share of that limit used at that moment; it drops when the limit resets." : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -18073,6 +18078,7 @@
}
},
"Plans without a separate 5-hour limit show only their 7-day line." : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -18105,6 +18111,7 @@
}
},
"Point at the chart to read every provider's usage at that time." : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -26012,6 +26019,7 @@
}
},
"Use the filter button to hide providers or limits. Your choice is remembered." : {
"extractionState" : "stale",
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
Expand Down Expand Up @@ -27239,4 +27247,4 @@
}
},
"version" : "1.1"
}
}
10 changes: 3 additions & 7 deletions RxCode/Views/Sidebar/RateLimitStatsPopovers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,6 @@ struct RateLimitHistoryPopover: View {
} else {
chart
legend
RateLimitGlossary(entries: [
.init(term: "Line", detail: "One provider's limit. Its height is the share of that limit used at that moment; it drops when the limit resets."),
.init(term: "Hover", detail: "Point at the chart to read every provider's usage at that time."),
.init(term: "Filter", detail: "Use the filter button to hide providers or limits. Your choice is remembered."),
.init(term: "7-day only", detail: "Plans without a separate 5-hour limit show only their 7-day line."),
])
}
}
.task(id: appState.rateLimitHistoryRevision) {
Expand Down Expand Up @@ -273,7 +267,7 @@ struct RateLimitHistoryPopover: View {
if let selectedDate {
RuleMark(x: .value("Time", selectedDate))
.foregroundStyle(ClaudeTheme.border)
.annotation(position: .top, overflowResolution: .init(x: .fit, y: .disabled)) {
.annotation(position: .top, spacing: 0, overflowResolution: .init(x: .fit(to: .chart), y: .fit(to: .chart))) {
readout(at: selectedDate)
}
}
Expand All @@ -296,6 +290,8 @@ struct RateLimitHistoryPopover: View {
}
.chartXSelection(value: $selectedDate)
.frame(height: 260)
// Room for the top "100%" axis label, which the scroll view would clip.
.padding(.top, 8)
}

/// Each provider's reading closest to the pointer.
Expand Down
Loading