Repository navigation
chore(deps): update rust crate pulldown-cmark to v0.13.6 [security] - #1353
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.13.5→0.13.6Quadratic parsing of nested image wikilinks with
ENABLE_WIKILINKSRUSTSEC-2026-0433
More information
Details
With
Options::ENABLE_WIKILINKS, handle_wikilink builds a wikilink's targetfrom the raw text of its body: scan_wikilink_pipe walks it looking for |, then
contains('\0') and from_replace_nuls walk it again.
Once a wikilink is created, disable_all_links only disables Link entries, so
every enclosing
![[stays live on the wikilink stack.On
![[![[![[…]]]]]]each of those openers then resolves in turn and rescanseverything inside it, which is quadratic in the nesting depth.
The event count stays tiny, because in the unpiped case each enclosing image
replaces its body with a fresh text node, so all of that work is thrown away.
Applications that parse untrusted Markdown with
ENABLE_WIKILINKSset,including through
Options::all(), are affected. The option is off by default.Parsing without it is not affected.
The flaw was fixed in
#1186 and
released in 0.13.6.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by OSV and the Rust Advisory Database (CC0 1.0).
Release Notes
raphlinus/pulldown-cmark (pulldown-cmark)
v0.13.6: Fix quadratic parsing of nested image wikilinksCompare Source
This version backports #1186 to fix quadratic parsing of nested image wikilinks.
Full Changelog: pulldown-cmark/pulldown-cmark@v0.13.5...v0.13.6
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.