Repository navigation
ci: check dependency changes for vulnerabilities - #1344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a dedicated Dependency Review workflow using GitHub's standard action, pinned to its v5.0.0 commit.
contents: read, do not persist checkout credentials, and do not post PR comments.This catches cases such as #1343 introducing vulnerable Undici through jsdom's development dependencies. A runtime-only check would miss it. It checks dependency changes, not the entire existing vulnerability backlog.
Validation
Executed the exact pinned action bundle with this workflow's inputs against GitHub's live dependency comparison API:
Also verified both action pins and release ages, parsed the workflow, ran
make format, Prettier checks, root lint, andgit diff --check.Required-check activation
This PR adds the check but does not change repository rules or merge settings. After it has run, add Dependency Review (source: GitHub Actions) as a required status check in an active ruleset targeting
main. Review the existing rules before activating that ruleset; it is currently disabled.