ast-grep + resolver v3 - #249
Merged
Merged
Conversation
### Summary Replace production unwraps, discarded Results, and verbose control flow reported by the imported ast-grep rules. Preserve the timer exit-status behavior, make Git staging failures observable at debug level, and use a lossy info-default RUST_LOG filter. ### Details Timer formatter tests now state why their operations must succeed. The docs command uses Option combinators, invalid TOML conversion retains its explicit invariant, and failed timer diagnostics remain non-fatal because stderr cannot report a write failure. `selfci check` passes lint and the code-level ast-grep scan; its ast-grep rule-test suite still fails in the parent rule-import change because four existing rule snapshots/expectations do not match rule behavior.
### Summary Update ast-grep test expectations and snapshots to match the imported rules’ actual diagnostics. Align the production unwrap rule exclusions with the fixture coverage, so ignored test code remains exempt while production code still fails the check. ### Details The unwrap-or-default test now flags only `unwrap_or_default`, which is the operation its rule matches. Regenerated snapshots remove obsolete condition labels and record the new unwrap-or-default diagnostic. The flake check now creates ignore fixtures at paths relative to the ast-grep project root, and `unwrap-in-prod` recognizes the same test path forms exercised by that check. ### Validation - `nix develop -c selfci check`
Cargo resolver 3 is valid for edition-2024 workspaces, but the lint treated every resolver except 2 as stale and its automatic fix rewrote 3 to 2. Accept resolver values 2 and 3 after Cargo metadata has validated the manifest. Continue recommending resolver 2 for missing, legacy, or malformed values. Add regression tests covering accepted resolver 2/3 values and rejected missing, v1, and non-string values. Reviews: - General review passed with no issues. The review covered correctness, test adequacy, Rust style, and Linked Specs consistency.
dpc
enabled auto-merge
July 28, 2026 20:30
dpc
added a commit
to dpc/flakebox
that referenced
this pull request
Jul 30, 2026
ast-grep + resolver v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.