Revert changing number of passes depending on number of parameters#2101
Open
sayantn wants to merge 1 commit intorust-lang:mainfrom
Open
Revert changing number of passes depending on number of parameters#2101sayantn wants to merge 1 commit intorust-lang:mainfrom
sayantn wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
revert the offset loading, instead load in a wrapping fashion
folkertdev
reviewed
May 4, 2026
Contributor
There was a problem hiding this comment.
what is this file for?
Contributor
Author
There was a problem hiding this comment.
oh sorry, that's my temporary log file, accidentally got committed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this causes buffer overflow in some x86 intrinsics with more than 20 parameters, e.g. _mm512_set_ph, so I decided to go to wrapping
cc @adamgemmell as this was added in #2087