Skip to content

Remove obsolete cfg for nvptx#1372

Merged
Amanieu merged 1 commit into
rust-lang:masterfrom
Urgau:remove-nvptx-cfgs
Jan 22, 2023
Merged

Remove obsolete cfg for nvptx#1372
Amanieu merged 1 commit into
rust-lang:masterfrom
Urgau:remove-nvptx-cfgs

Conversation

@Urgau

@Urgau Urgau commented Jan 19, 2023

Copy link
Copy Markdown
Member

This PR removes the last target_arch=nvptx in accordance to the compiler MCP 496 (rust-lang/compiler-team#496). It came up when cleaning up bootstrap extra cfgs (rust-lang/rust#107080).

@rustbot

rustbot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@Urgau

Urgau commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

Should I rename the nvptx module and all reference to nvptx64 ?

@Urgau

Urgau commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

CI failure is fixed by #1371.

@Amanieu

Amanieu commented Jan 22, 2023

Copy link
Copy Markdown
Member

LGTM! Can you rebase now that #1371 is merged?

Following to the compiler MCP 496
(rust-lang/compiler-team#496)
@Urgau Urgau force-pushed the remove-nvptx-cfgs branch from 84faff3 to 3a0b751 Compare January 22, 2023 17:22
@Urgau

Urgau commented Jan 22, 2023

Copy link
Copy Markdown
Member Author

LGTM! Can you rebase now that #1371 is merged?

Done. CI now pass.

@Amanieu Amanieu merged commit af225b6 into rust-lang:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants