Skip to content

Add Fuchsia support and CI#164

Merged
Thomasdezeeuw merged 1 commit into
rust-lang:masterfrom
tamird:fuchsia-support
Dec 25, 2020
Merged

Add Fuchsia support and CI#164
Thomasdezeeuw merged 1 commit into
rust-lang:masterfrom
tamird:fuchsia-support

Conversation

@tamird

@tamird tamird commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

In general, feature support is identical to Linux.

Updates #78.

@Thomasdezeeuw Thomasdezeeuw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, but LGTM otherwise.

Comment thread src/sys/unix.rs
Comment thread src/sys/unix.rs
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

@tamird is there manual online for libc/POSIX complicated system call interface for Fuchsia? A link I can add to #154?

@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

For myself, update #78.

@tamird

tamird commented Dec 25, 2020

Copy link
Copy Markdown
Contributor Author

@tamird is there manual online for libc/POSIX complicated system call interface for Fuchsia? A link I can add to #154?

Not that I'm aware of at this time. Fuchsia's libc is derived from musl, so it is largely in line with Linux (or is intended to be, in areas where it is not yet so).

In general, feature support is identical to Linux.
@Thomasdezeeuw Thomasdezeeuw merged commit efa912a into rust-lang:master Dec 25, 2020
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Thanks @tamird.

@tamird tamird deleted the fuchsia-support branch December 25, 2020 14:37
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Hey @tamird, apparently Fuchsia doesn't yet work. I tried checking it locally and found the following errors:

error[E0425]: cannot find value `IFNAMSIZ` in crate `libc`
   --> src/sys/unix.rs:934:46
    |
934 |         let mut buf: [MaybeUninit<u8>; libc::IFNAMSIZ] =
    |                                              ^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `IFNAMSIZ` in crate `libc`
   --> src/sys/unix.rs:935:60
    |
935 |             unsafe { MaybeUninit::<[MaybeUninit<u8>; libc::IFNAMSIZ]>::uninit().assume_init() };
    |                                                            ^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `IP_FREEBIND` in crate `libc`
    --> src/sys/unix.rs:1049:69
     |
1049 |             getsockopt::<c_int>(self.inner, libc::SOL_SOCKET, libc::IP_FREEBIND)
     |                                                                     ^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `IP_FREEBIND` in crate `libc`
    --> src/sys/unix.rs:1072:23
     |
1072 |                 libc::IP_FREEBIND,
     |                       ^^^^^^^^^^^ not found in `libc`

So IFNAMSIZ and IP_FREEBIND aren't defined. It's also a problem in the CI, but it passed anyway (now issue #169). Are these two constant available already in Fuchsia?

@tamird

tamird commented Dec 26, 2020

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants