Skip to content

Add miri to rustup#1606

Merged
nrc merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-2
Jan 14, 2019
Merged

Add miri to rustup#1606
nrc merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-2

Conversation

@oli-obk

@oli-obk oli-obk commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

It was just added to the distribution in rust-lang/rust#57086

This PR enables calling cargo miri after installing the miri component

@kinnison

kinnison commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

Would it make sense to have a component_for_bin() to map cargo-miri to miri ?

@oli-obk

oli-obk commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

I was considering that, but I felt like miri is niche enough so it won't impact too many ppl. I can change it though if anyone thinks it's worthwile

@kinnison

kinnison commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

component_for_bin() is pretty much only used to suggest component names to install if something is missing, but if someone tries to run cargo miri ... and then doesn't get the hint, they might be upset.

I don't mind either way, just thought i'd mention it in case you hadn't already considered and discarded the idea :-D

@kinnison

kinnison commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

Change-wise this looks good 👍 but I would be more comfortable if it were rebased so that there aren't fixup commits in the sequence. I can do this if you don't have time, so long as someone can tell me how to update someone else's PR :-)

@oli-obk

oli-obk commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

Updated

@kinnison kinnison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nrc I think this is good for merge. I can't see any reason why it'd break anything.

@nrc nrc merged commit ab224e4 into rust-lang:master Jan 14, 2019
@nrc

nrc commented Jan 14, 2019

Copy link
Copy Markdown
Member

Thanks!

@aleksmelnikov

Copy link
Copy Markdown

Will miri component be availiable in the next rustup release (1.17.0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants