Document the SessionDiagnostic derive macro.#961
Merged
Conversation
oli-obk
approved these changes
Nov 15, 2020
oli-obk
left a comment
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
This is awesome! Thanks for writing it up. I think with this we can now start creating E-easy issues for various sites in the compiler where we could move to SessionDiagnostic
LeSeulArtichaut
previously requested changes
Nov 15, 2020
LeSeulArtichaut
left a comment
LeSeulArtichaut
left a comment
Contributor
There was a problem hiding this comment.
Some lines are too long and exceed the 100 characters limit required to pass CI. I'd suggest to use [][]-style links instead of the inline []()-style links.
Contributor
|
Also this design looks fantastic! It's awesome that someone finally implemented it ❤️ |
LeSeulArtichaut
added
the
S-waiting-on-author
camelid
reviewed
Nov 15, 2020
camelid
left a comment
camelid
left a comment
Member
There was a problem hiding this comment.
This feature looks pretty cool!
Co-authored-by: Camelid <camelidcamel@gmail.com>
jumbatm
force-pushed
the
SessionDiagnostic
branch
from
1dd467f to
01be82c
Compare
Contributor
Author
|
Thanks for the suggestions, all :) @rustbot modify labels: waiting-on-review |
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
#[derive(SessionDiagnostic)macro implemented in rust-lang/rust#75138.cc @oli-obk