Skip to content

Updates prereqs to build LLVM from source for C++17.#1448

Merged
tshepang merged 3 commits into
rust-lang:masterfrom
red1bluelost:master
Aug 27, 2022
Merged

Updates prereqs to build LLVM from source for C++17.#1448
tshepang merged 3 commits into
rust-lang:masterfrom
red1bluelost:master

Conversation

@red1bluelost

Copy link
Copy Markdown
Contributor

With the recent upgrade to C++17 in LLVM, this increases the minimum requirements for building LLVM from source. Matches those at https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library

@tshepang

tshepang commented Aug 27, 2022

Copy link
Copy Markdown
Member

do these minimums apply to older llvm versions, which we support

@red1bluelost

Copy link
Copy Markdown
Contributor Author

Good point! LLVM upgraded on August 6 which was very recent. Rust's fork of LLVM is still using C++14 so the old compilers would still be viable.
Maybe this PR can just be blocked until Rust updates the fork to the C++17 LLVM.

@tshepang

tshepang commented Aug 27, 2022

Copy link
Copy Markdown
Member

the text could be changed to link to pre-reqs pages of the supported llvm versions, which can be older than the fork

@red1bluelost

Copy link
Copy Markdown
Contributor Author

I edited the text point to the recent LLVM 14 release documentation and added a date check comment. Does this work?

Comment thread src/building/prerequisites.md Outdated
@tshepang

Copy link
Copy Markdown
Member

it does, thanks

@tshepang tshepang merged commit daca468 into rust-lang:master Aug 27, 2022
@tshepang

tshepang commented Aug 27, 2022

Copy link
Copy Markdown
Member

I edited the text point to the recent LLVM 14 release documentation and added a date check comment.

I assume you meant LLVM 13

@red1bluelost

Copy link
Copy Markdown
Contributor Author

Yes, oops my comment was wrong. The docs match regardless but I put 13 since it counts as one of the "last few" releases.

@tshepang

Copy link
Copy Markdown
Member

it looks like the oldest one supported by nightly rust-lang/rust#100460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants